8000 switch to github lgtm by denis-yuen · Pull Request #208 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

switch to github lgtm #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

switch to github lgtm #208

merged 1 commit into from
Nov 22, 2022

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Nov 17, 2022 •
edited
Loading

Description
Enable CodeQL check (replacement for LGTM)
https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/

Will disable LGTM integration from the web console on merge

Review Instructions
See that recent builds have LGTM migrated checks
They should show up in https://github.com/dockstore/dockstore-cli/security/code-scanning

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-3011

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Nov 17, 2022
@denis-yuen
Copy link
Member Author

See also dockstore/dockstore#5244

@denis-yuen denis-yuen marked this pull request as ready for review November 17, 2022 21:12
@denis-yuen
Copy link
Member Author

Note: lgtm fails since we're removinng it, codeql fails since there is no build on develop to compare with (yet)

@denis-yuen denis-yuen requested review from david4096, a team, kathy-t and hyunnaye and removed request for a team November 17, 2022 21:13
@denis-yuen denis-yuen requested a review from coverbeck November 21, 2022 15:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Base: 68.22% // Head: 68.20% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d971a28) compared to base (88313ce).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
- Coverage    68.22%   68.20%   -0.02%     
===========================================
  Files           49       49              
  Lines         6014     6014              
  Branches       793      793              
===========================================
- Hits          4103     4102       -1     
  Misses        1577     1577              
- Partials       334      335       +1
Flag Coverage Δ
bitbuckettests 9.89% <ø> (ø)
confidentialtooltests 53.58% <ø> (ø)
confidentialworkflowtests 28.38% <ø> (ø)
nonconfidentialtests 32.77% <ø> (-0.02%) ⬇️
singularitytests 16.69% <ø> (ø)
unittests 8.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/io/github/collaboratory/cwl/CWLClient.java 80.28% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen 8840 merged commit 1b9ce85 into develop Nov 22, 2022
@denis-yuen denis-yuen deleted the feature/lgtm_migration branch November 22, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

@hyunnaye hyunnaye hyunnaye approved these changes

@david4096 david4096 Awaiting requested review from david4096

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denis-yuen @coverbeck @kathy-t @hyunnaye
0