java 17 and compile issue with trs api #211
Conversation
Codecov ReportBase: 68.17% // Head: 69.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
=============================================
+ Coverage 68.17% 69.24% +1.06%
- Complexity 0 1038 +1038
=============================================
Files 49 46 -3
Lines 6014 5940 -74
Branches 793 776 -17
=============================================
+ Hits 4100 4113 +13
+ Misses 1577 1503 -74
+ Partials 337 324 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
looking into coverage drop |
|
Kudos, SonarCloud Quality Gate passed! |
|
code scanning is a false positive created by pinning the java version |
| strategy: | ||
| matrix: | ||
| java: [ '11', '17' ] | ||
| java: [ '17.0.4+8' ] |
There was a problem hiding this comment.
Is it intentional this is different that the Circle CI version (17.0.3)?
There was a problem hiding this comment.
No, I think this is just pinned to the same as in the webservice repo.
Description
Working on getting the nightly cron job to build properly post TRS update (but before avro revert)
Also updating to Java 17 with main debate in dockstore/dockstore#5279
Coverage problem turned out to be a problem with jacoco's interaction with how surefire/failsafe fork VMs. Found a way to append arguments to the forked vm including jacoco without overwriting other custom arguments
Do not merge before dockstore/dockstore#5279
Review Instructions
Builds including overnight build should work
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4477
Blocks https://ucsc-cgl.atlassian.net/browse/SEAB-5070
Created dockstore/dockstore#5284 since system rules, junit4, seem on their last legs in Java 17
Created follow-up for quickstart and dockstore-documentation(?) https://ucsc-cgl.atlassian.net/browse/SEAB-5074
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install