8000 Update template with security section by coverbeck · Pull Request #212 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update template with security section #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

Update template with security section #212

merged 1 commit into from
Dec 21, 2022

Conversation

coverbeck
Copy link
Contributor
@coverbeck coverbeck commented Dec 21, 2022 •
edited
Loading

Description
Add a security section to PR template

Review Instructions
You should see the security section when creating a new PR.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5077

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck requested review from denis-yuen and svonworl December 21, 2022 01:00 8000
@coverbeck coverbeck self-assigned this Dec 21, 2022
denis-yuen
denis-yuen approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member
@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably have skipped CI (IT failure)

@coverbeck
Copy link
Contributor Author

could probably have skipped CI (IT failure)

I should have for this repo; it leads to issues in dockstore and web-service but not here.

@coverbeck coverbeck merged commit c9da66d into develop Dec 21, 2022
@coverbeck coverbeck deleted the feature/seab-5077/security branch December 21, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-yuen denis-yuen denis-yuen approved these changes

@svonworl svonworl svonworl approved these changes

Assignees

@coverbeck coverbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coverbeck @denis-yuen @svonworl
0