SEAB-5247: Add MuteForSuccessfulTests extension to CLI #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.73% // Head: 69.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #224 +/- ##
=============================================
- Coverage 69.73% 69.37% -0.37%
+ Complexity 1076 1046 -30
=============================================
Files 47 47
Lines 6050 6050
Branches 796 796
=============================================
- Hits 4219 4197 -22
- Misses 1510 1515 +5
- Partials 321 338 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
denis-yuen
approved these changes
Feb 14, 2023
| @ExtendWith(SystemStubsExtension.class) | ||
| @ExtendWith(MuteForSuccessfulTests.class) | ||
| @ExtendWith(BaseIT.TestStatus.class) |
There was a problem hiding this comment.
BaseIT redundant here, but probably not worth fixing unless there are other issues
coverbeck
approved these changes
Feb 15, 2023
fhembroff
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds our new
MuteForSuccessfulTestsJunit 5 extension to the CLI tests.Important changes include:
dockstore-core.versionto1.14.0-alpha.7(to reference the new extension).confidential4paths to.gitignore, even though they're not included in the bundle, because I'd added them for another change that got reverted, but there's no harm in leaving them.Review Instructions
Find a failed CircleCI run that incorporates these changes and confirm that the stdout/stderr output is included with, and only with, the failures.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5247
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install