Remove swagger client in favour of openapi client #249

denis-yuen · 2023-06-22T17:58:46Z

Description
Remove swagger client in favour of openapi client

Review Instructions
Should just function the same as before, could spot check a handful of operations like talking to the server via server-metadata, download a workflow via zip to ensure that there are no classpath issues

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5652

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

Check that you pass the basic style checks and unit tests by running ./mvnw clean install
If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

codecov · 2023-06-22T19:09:39Z

Codecov Report

Patch coverage: 82.05% and project coverage change: +0.82 🎉

Comparison is base (1d3ac93) 69.46% compared to head (4888fc2) 70.28%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #249      +/-   ##
=============================================
+ Coverage      69.46%   70.28%   +0.82%     
- Complexity      1038     1051      +13     
=============================================
  Files             47       47              
  Lines           6071     6067       -4     
  Branches         799      799              
=============================================
+ Hits            4217     4264      +47     
+ Misses          1513     1454      -59     
- Partials         341      349       +8

Flag	Coverage Δ
bitbuckettests	`9.84% <30.76%> (-0.03%)`	⬇️
confidentialtooltests	`55.69% <51.28%> (+0.82%)`	⬆️
confidentialworkflowtests	`30.54% <64.10%> (+2.55%)`	⬆️
nonconfidentialtests	`32.33% <7.69%> (-0.03%)`	⬇️
singularitytests	`16.56% <7.69%> (-0.03%)`	⬇️
unittests	`8.32% <7.69%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../java/io/dockstore/client/cli/ArgumentUtility.java	`81.54% <ø> (ø)`
...in/java/io/dockstore/client/cli/CheckerClient.java	`60.56% <0.00%> (ø)`
...ain/java/io/dockstore/client/cli/SearchClient.java	`0.00% <0.00%> (ø)`
...n/java/io/dockstore/client/cli/SwaggerUtility.java	`81.81% <ø> (-0.80%)`	⬇️
...ockstore/client/cli/nested/BaseLanguageClient.java	`60.00% <ø> (ø)`
...ava/io/dockstore/client/cli/nested/DepCommand.java	`58.06% <ø> (ø)`
.../io/dockstore/common/ToolWorkflowDeserializer.java	`0.00% <ø> (ø)`
...in/java/io/github/collaboratory/cwl/CWLClient.java	`80.10% <ø> (ø)`
...ub/collaboratory/cwl/cwlrunner/CWLToolWrapper.java	`86.66% <ø> (ø)`
...oratory/cwl/cwlrunner/GenericCWLRunnerWrapper.java	`83.33% <ø> (ø)`
... and 10 more