add github actions for release #241
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #241 +/- ##
=============================================
- Coverage 68.19% 66.71% -1.49%
+ Complexity 1032 1007 -25
=============================================
Files 47 47
Lines 6081 6081
Branches 802 802
=============================================
- Hits 4147 4057 -90
- Misses 1581 1690 +109
+ Partials 353 334 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Was looking at the wiki and noticed that the Dockstore webservice release instructions don't mention creating a GitHub pre-release and attaching the latest CLI dockstore script to the newly drafted webservice release (which are instructions included in the 1.14 staging checklist) |
dockstore-client/pom.xml
8000
Outdated
| <artifacts> | ||
| <artifact> | ||
| <file>target/dockstore</file> | ||
| <type>.</type> |
There was a problem hiding this comment.
Was looking on artifactory for this dockstore script and realized it's this file https://artifacts.oicr.on.ca/artifactory/collab-release/io/dockstore/dockstore-client/1.15.0-alpha.3/dockstore-client-1.15.0-alpha.3-dist..
I find the name to be confusing and at first glance at the folder, I couldn't find the dockstore script. We've set the type to be the file name for the openapi and swagger files before here:
https://github.com/dockstore/dockstore/blob/9897d1e08e5281db2966763cd707528a329437f8/dockstore-webservice/pom.xml#L1401
So the file name in artifactory is clearer since it ends in, for example, openapi.yaml. I suggest using the type to set a clearer name for the file, like dockstore
There was a problem hiding this comment.
Yeah, this was an abortive attempt to use https://stackoverflow.com/questions/27053162/how-to-attach-additional-binary-artifacts-without-type-with-maven-build-helper-m which seems bugged.
I think <type>dockstore</type> will result in dockstore-client-1.15.0-alpha.3-dist.dockstore which, ok.
Should be there, search for "For the CLI only" between Step 2 and 3 |
Oh, I meant for the webservice release, not the CLI. The checklist says that the latest CLI dockstore script should be attached to the webservice release |
Hmmm, that seems like a mistake (regression rather) then. The UI quickstart links to the cli repo not the webservice repo https://dockstore.org/quick-start |
| @@ -0,0 +1,88 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| ~ Copyright 2017 OICR | |||
There was a problem hiding this comment.
Interesting, I never read these because they're generated. Turns out, whatever plugin we're using copies the copyright notice from the module pom
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Added github action to cli repo, tested it out with a few alpha releases of the cli (1 through 3)
wiki updated to indicate that the cli and webservice are now basically released the same way without needing individual artifactory accounts https://wiki.oicr.on.ca/display/DOC/Dockstore+Releases#DockstoreReleases-RepositoriesthatuseFriendlyCIversionsandaGitHubAction
This now includes #242 which may be better to review first. I also noticed github actions reusable workflows late, so re-worked to use that to DRY
Review Instructions
Take a look at the wiki instructions, could do another cli release
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5516
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install