8000 add broad mirror by denis-yuen · Pull Request #258 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add broad mirror #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

add broad mirror #258

merged 1 commit into from
Sep 11, 2023

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Sep 5, 2023

Description
Most configuration is done on artifactory, but adding reference to it here

Review Instructions
no change, but build should still function if the broad goes down

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5824

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Sep 5, 2023
@denis-yuen denis-yuen changed the title add cache add broad mirror Sep 5, 2023
@sonarqubecloud
Copy link
sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (f1bdd58) 70.21% compared to head (db13f80) 70.31%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #258      +/-   ##
=============================================
+ Coverage      70.21%   70.31%   +0.09%     
- Complexity      1066     1068       +2     
=============================================
  Files             47       47              
  Lines           6070     6070              
  Branches         799      799              
=============================================
+ Hits            4262     4268       +6     
+ Misses          1471     1466       -5     
+ Partials         337      336       -1     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.91% <ø> (-0.02%) ⬇️
confidentialworkflowtests 30.34% <ø> (ø)
nonconfidentialtests 32.40% <ø> (+0.11%) ⬆️
singularitytests 16.58% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen marked this pull request as ready for review September 6, 2023 14:07
@denis-yuen denis-yuen requested review from a team, david4096, kathy-t, hyunnaye and coverbeck and removed request for a team September 6, 2023 14:07
@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye and svonworl and removed request for david4096, hyunnaye, coverbeck and a team September 11, 2023 14:57
@denis-yuen denis-yuen merged commit 63687b9 into develop Sep 11, 2023
@denis-yuen denis-yuen deleted the feature/broad_cache branch September 11, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0