need this for failing cron with current develop #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #263 +/- ##
=============================================
+ Coverage 54.34% 55.65% +1.30%
- Complexity 887 907 +20
=============================================
Files 47 47
Lines 6070 6070
Branches 799 799
=============================================
+ Hits 3299 3378 +79
+ Misses 2406 2339 -67
+ Partials 365 353 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kathy-t
approved these changes
Nov 21, 2023
| @@ -69,6 +69,29 @@ org.broadinstitute--wdl-biscayne_2.13--84=WDL License https://github.com/openwdl | |||
| org.broadinstitute--wdl-draft2_2.13--84=WDL License https://github.com/openwdl/wdl/blob/master/LICENSE | |||
| org.broadinstitute--wdl-draft3_2.13--84=WDL License https://github.com/openwdl/wdl/blob/master/LICENSE | |||
|
|
|||
| # delete previous org.broadinstitute group aftera tag after 1.15.0-alpha.13 is created and merged | |||
There was a problem hiding this comment.
FYI, I created a 1.15.0-alpha.13 webservice tag this morning https://github.com/dockstore/dockstore/releases/tag/1.15.0-alpha.13
hyunnaye
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failing cron builds ( https://github.com/dockstore/dockstore-cli/actions/workflows/cron.yml ) due to cromwell update in webservice develop dockstore/dockstore#5741
Note, this is an example of a case where the cron builds are working to some extent
https://ucsc-cgl.atlassian.net/browse/SEAB-5853 @coverbeck
Review Instructions
After merge, the cron builds (first link) should be working again
Issue
n/a
Noted while doing email triage
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install