simple password vault integration based on psql suggestion #308
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
=============================================
- Coverage 23.83% 23.80% -0.04%
+ Complexity 402 398 -4
=============================================
Files 48 48
Lines 6041 6046 +5
Branches 798 800 +2
=============================================
- Hits 1440 1439 -1
- Misses 4416 4418 +2
- Partials 185 189 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
kathy-t
approved these changes
May 30, 2025
svonworl
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by https://postgrespro.com/list/thread-id/2396558 a proposal on how to make pgsql and it's use of pgpass more secure. That proposal did not seem to come to fruition, but seems like a simple/elegant way to allow a user concerned about storing passwords/auth tokens on disk to store them instead in some kind of password vault or manager.
Review Instructions
Use the CLI, put your token in another file and
catit as atokenCommandSpun off documentation as https://ucsc-cgl.atlassian.net/browse/SEAB-7171
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7032
Security
None, this is intended to improve security by providing a workaround to storing the auth token on disk.
./mvnw clean install