Fix nightly CLI build #310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #310 +/- ##
=============================================
+ Coverage 23.73% 23.76% +0.03%
- Complexity 395 397 +2
=============================================
Files 48 48
Lines 6046 6046
Branches 800 800
=============================================
+ Hits 1435 1437 +2
Misses 4420 4420
+ Partials 191 189 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -276,18 +274,6 @@ | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
| <artifactId>commons-vfs2</artifactId> | |||
| <!-- remove after bom is updated with Dockstore or above 1.14.0 --> | |||
| <version>2.10.0</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
It's unclear to me if these exclusions should be kept
There was a problem hiding this comment.
I think commons-httpclient, you can try building without it (I think this was a crude way of managing which versions we got).
I think hadoop-hdfs-client can stay excluded (I'm pretty sure we'll never use it, it's integration with the hadoop file system)
| @@ -276,18 +274,6 @@ | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
| & 8000 lt;artifactId>commons-vfs2</artifactId> | |||
| <!-- remove after bom is updated with Dockstore or above 1.14.0 --> | |||
| <version>2.10.0</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
I think commons-httpclient, you can try building without it (I think this was a crude way of managing which versions we got).
I think hadoop-hdfs-client can stay excluded (I'm pretty sure we'll never use it, it's integration with the hadoop file system)
|
Description
This PR fixes the nightly CLI build that has been failing (can see the failed message in dockstore-dev-alerts). Fixed it by creating a new 1.18.0-alpha.1 webservice tag and removing specific versions of some dependencies that are already specified in the bom-internal. See passing nightly build here https://app.circleci.com/pipelines/github/dockstore/dockstore-cli/2324/workflows/28b21063-0847-4773-a3b4-907b02939f9c
Review Instructions
Nightly CLI build should pass
Issue
n/a
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install