Feature/core update ai topic hookup #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-yuen
commented
Jun 10, 2024
| @@ -478,7 +478,7 @@ static List<String> getSourceUrlComponents(String sourceUrl) { | |||
| private Optional<String> getPrimaryDescriptorAbsolutePath(WorkflowsApi workflowsApi, MinimalWorkflowInfo workflow, String version) { | |||
| Optional<String> primaryDescriptorPath = Optional.empty(); | |||
| try { | |||
| primaryDescriptorPath = Optional.of(workflowsApi.primaryDescriptor1(workflow.id(), version, workflow.descriptorType().toString()).getAbsolutePath()); | |||
There was a problem hiding this comment.
Sigh @ swagger client parameter re-arrangement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #493 +/- ##
=============================================
+ Coverage 48.42% 48.44% +0.02%
Complexity 305 305
=============================================
Files 46 46
Lines 2480 2481 +1
Branches 200 200
=============================================
+ Hits 1201 1202 +1
Misses 1187 1187
Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kathy-t
approved these changes
Jun 10, 2024
svonworl
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update core jar and fix known ai topic upload breakage
Trivial update and parameter re-arrangement that took way too long to debug, looking for more sophisticated issue
Review Instructions
Build passes, could run
testUploadAITopicstest and note that workflow version has a "processed" propertyIssue
https://ucsc-cgl.atlassian.net/browse/SEAB-6485
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)