download workflows and test clam #514
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #514 +/- ##
=============================================
+ Coverage 9.90% 10.34% +0.44%
Complexity 75 75
=============================================
Files 44 43 -1
Lines 2372 2271 -101
Branches 203 194 -9
=============================================
Hits 235 235
+ Misses 2121 2020 -101
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| ZipEntry entry = entries.nextElement(); | ||
| File entryDestination = new File(dirVersionPath, entry.getName()); | ||
| if (entry.isDirectory()) { | ||
| entryDestination.mkdirs(); |
Check failure
Code scanning / SonarCloud
Extracting archives should not lead to zip slip vulnerabilities High
There was a problem hiding this comment.
Do any READMEs have to updated due to these changes? Maybe https://github.com/dockstore/dockstore-support?tab=readme-ov-file#client?
if no dockstore-support cache is available
but other changes seemed to have worked
|
Description
Killing a couple birds with one stone, this module is becoming less relevant since it doesn't seem we're going to be backing up docker containers ourselves. So rigging this up to download descriptors so that we can run clamav on them ourselves. More details on JIRA
Review Instructions
Could replicate process in JIRA if desired
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6983
Security
Not exactly, but could cause annoying WAF noise
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)