8000 cwlavro upgrade by denis-yuen · Pull Request #5772 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cwlavro upgrade #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

cwlavro upgrade #5772

merged 1 commit into from
Jan 2, 2024

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Dec 18, 2023 •
edited
Loading

Description
Use result of dockstore/cwlavro#42

Review Instructions
Import or update a few cwl workflows, check that we're processing CWL correctly

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6017

Security and Privacy
None, should help though with linked issue

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Dec 18, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link
codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f59ba3) 73.03% compared to head (21772b7) 74.36%.
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5772      +/-   ##
=============================================
+ Coverage      73.03%   74.36%   +1.33%     
- Complexity      5082     5182     +100     
=============================================
  Files            357      357              
  Lines          18792    18792              
  Branches        1997     1997              
=============================================
+ Hits           13724    13975     +251     
+ Misses          4095     3865     -230     
+ Partials         973      952      -21
Flag Coverage Δ
bitbuckettests 27.33% <ø> (ø)
integrationtests 58.90% <ø> (ø)
languageparsingtests 10.90% <ø> (ø)
localstacktests 20.72% <ø> (ø)
regressionintegrationtests ?
toolintegrationtests 30.70% <ø> (ø)
unit-tests_and_non-confidential-tests 29.00% <ø> (ø)
workflowintegrationtests 39.04% <ø> (+3.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen changed the title upgrades, test them cwlavro upgrade Dec 18, 2023
@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye and svonworl and removed request for a team December 18, 2023 20:59
@denis-yuen denis-yuen marked this pull request as ready for review December 18, 2023 20:59
@denis-yuen denis-yuen requested a review from kathy-t December 18, 2023 21:00
@kathy-t
Copy link
Contributor
kathy-t commented Dec 22, 2023

Checklist is unchecked 🙂

@denis-yuen denis-yuen merged commit fb52400 into develop Jan 2, 2024
@denis-yuen denis-yuen deleted the avro_update branch January 2, 2024 16:55
denis-yuen added a commit that referenced this pull request Jan 2, 2024
@denis-yuen
upgrades, test them (#5772)
75df03e
@denis-yuen denis-yuen mentioned this pull request Jan 2, 2024
Merged
9 tasks
denis-yuen added a commit that referenced this pull request Jan 3, 2024
@denis-yuen
avro update (#5772) (#5776)
a4aa717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathy-t kathy-t kathy-t approved these changes

@svonworl svonworl svonworl approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @kathy-t @svonworl
0