8000 clean-up zenodo reference to wrong repo by denis-yuen · Pull Request #5784 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

clean-up zenodo reference to wrong repo #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

clean-up zenodo reference to wrong repo #5784

merged 1 commit into from
Jan 11, 2024

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jan 10, 2024 •
edited
Loading

Description
Supporting PR for zenodo clean-up and removal

Review Instructions
Build should pass after merging pretty much (there should be no functional change)

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6049

Security and Privacy

No change

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov Codecov
Copy link
codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a4789) 70.86% compared to head (bf71b2a) 74.36%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5784      +/-   ##
=============================================
+ Coverage      70.86%   74.36%   +3.49%     
- Complexity      4941     5181     +240     
=============================================
  Files            357      357              
  Lines          18793    18793              
  Branches        1997     1997              
=============================================
+ Hits           13318    13975     +657     
+ Misses          4522     3865     -657     
  Partials         953      953
Flag Coverage Δ
bitbuckettests 27.32% <ø> (-0.01%) ⬇️
integrationtests 58.91% <ø> (+4.46%) ⬆️
languageparsingtests 10.90% <ø> (ø)
localstacktests 20.72% <ø> (ø)
toolintegrationtests 30.70% <ø> (ø)
unit-tests_and_non-confidential-tests 29.00% <ø> (ø)
workflowintegrationtests 39.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen
Copy link
Member Author

This is paired with dockstore/swagger-java-zenodo-client#15 (review)

@denis-yuen denis-yuen marked this pull request as ready for review January 10, 2024 22:21
@denis-yuen denis-yuen requested review from a team, david4096, svonworl, ll5zh, coverbeck and kathy-t and removed request for a team January 10, 2024 22:21
@denis-yuen denis-yuen self-assigned this Jan 10, 2024
coverbeck
coverbeck approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator
@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to target the release branch? No idea if so, just making sure

@denis-yuen
Copy link
Member Author

No, I think I'd like to leave the clean-up for 1.16 (the actual fix is already in 1.15)
8000

@denis-yuen denis-yuen merged commit 3879929 into develop Jan 11, 2024
@denis-yuen denis-yuen deleted the feature/zenodo_cleanup branch January 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@svonworl svonworl svonworl approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@ll5zh ll5zh Awaiting requested review from ll5zh ll5zh was automatically assigned from dockstore/dockstore

@kathy-t kathy-t Awaiting requested review from kathy-t

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @coverbeck @svonworl
0