SEAB-6083: Remove deprecated properties from Entry #5811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5811 +/- ##
=============================================
- Coverage 74.40% 74.39% -0.01%
+ Complexity 5267 5265 -2
=============================================
Files 365 365
Lines 19046 19042 -4
Branches 2021 2021
=============================================
- Hits 14171 14167 -4
Misses 3917 3917
Partials 958 958
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Cool, thanks for double-checking! |
denis-yuen
approved these changes
Feb 16, 2024
coverbeck
approved these changes
Feb 20, 2024
kathy-t
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes two deprecated accessors/properties,
authorandemail, from Entry.I checked the latest develop versions of the UI and CLI against my local deployment of this PR, and they appeared to work without issue. I thought the CLI might bomb when I retrieved the information for a workflow, but it appears to have been weaned off the deprecated properties in dockstore/dockstore-cli#269.
Branch name contains the wrong ticket name/number, my copy-paste was errant.
Review Instructions
Check
openapi.yamland confirm that the properties are no longer present.Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6083
Security and Privacy
No concerns.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation