8000 SEAB-6266: Update deprecated CircleCI images by ll5zh · Pull Request #5823 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SEAB-6266: Update deprecated CircleCI images #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2024
Merged

SEAB-6266: Update deprecated CircleCI images #5823

merged 2 commits into from
Feb 27, 2024

Conversation

ll5zh
Copy link
Contributor
@ll5zh ll5zh commented Feb 26, 2024

Description
Our CircleCI configuration currently uses the Linux image ubuntu-2204:2022.10.1 and the remote Docker version 20.10.17, both of which will no longer be supported starting September 30th, 2024 (sources: Linux, Docker).

CircleCI jobs with deprecation warnings: language-parsing-tests (Linux), localstack-tests (Linux), integration-tests (Docker).

This PR updates the Linux image to ubuntu-2204:2023.10.1, and the remote Docker image to docker24.

Review Instructions
The CircleCI jobs should pass, and the ones that had deprecations should no longer report warnings.

Issue
SEAB-6266

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here.

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@ll5zh ll5zh self-assigned this Feb 26, 2024
@codecov Codecov
Copy link
codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.40%. Comparing base (91643fe) to head (aa9ee95).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #5823   +/-   ##
==========================================
  Coverage      74.40%   74.40%           
  Complexity      5266     5266           
==========================================
  Files            365      365           
  Lines          19042    19042           
  Branches        2021     2021           
==========================================
  Hits           14168    14168           
  Misses          3917     3917           
  Partials         957      957
Flag Coverage Δ
bitbuckettests 27.03% <ø> (-0.02%) ⬇️
integrationtests 58.25% <ø> (ø)
languageparsingtests 10.83% <ø> (ø)
localstacktests 21.47% <ø> (ø)
toolintegrationtests 30.38% <ø> (ø)
unit-tests_and_non-confidential-tests 28.72% <ø> (ø)
workflowintegrationtests 38.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denis-yuen
denis-yuen approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member
@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ll5zh ll5zh merged commit 54338e0 into develop Feb 27, 2024
@ll5zh ll5zh deleted the seab-6266/update-linux-image branch February 27, 2024 21:59
denis-yuen pushed a commit that referenced this pull request May 27, 2024
@ll5zh @denis-yuen
SEAB-6266: Update deprecated CircleCI images (#5823)
b26a848 
* try bumping linux image to 2023.10.1

* try updating remote docker to docker24
denis-yuen pushed a commit that referenced this pull request May 29, 2024
@ll5zh @denis-yuen
SEAB-6266: Update deprecated CircleCI images (#5823)
2fbc212 
* try bumping linux image to 2023.10.1

* try updating remote docker to docker24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@svonworl svonworl svonworl approved these changes

Assignees

@ll5zh ll5zh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ll5zh @coverbeck @denis-yuen @svonworl
0