8000 Feature/param version openapi by denis-yuen · Pull Request #5840 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/param version openapi #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2024
Merged

Feature/param version openapi #5840

merged 3 commits into from
Mar 14, 2024

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Mar 13, 2024 •
edited
Loading

Description
Missed a variable during the dropwizard 4.0 upgrade
https://github.com/dockstore/dockstore/pull/5483/files#diff-37d9724cc211c84769018776af491d71c6810730cc5e967e113ac8ea87e2e3e2

Adding it back so the live openapi.yaml will have the correct version

Review Instructions
Take a look on the swagger-ui page to see if the right version comes up

Issue
n/a

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Mar 13, 2024
@denis-yuen denis-yuen requested review from coverbeck, a team, david4096, ll5zh and kathy-t and removed request for a team March 13, 2024 20:53
@denis-yuen denis-yuen marked this pull request as ready for review March 13, 2024 21:12
@codecov Codecov
Copy link
codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.47%. Comparing base (e6a5182) to head (dc973d5).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #5840   +/-   ##
==========================================
  Coverage      74.47%   74.47%           
  Complexity      5266     5266           
==========================================
  Files            366      366           
  Lines          19031    19031           
  Branches        2021     2021           
==========================================
  Hits           14173    14173           
  Misses          3901     3901           
  Partials         957      957
Flag Coverage Δ
bitbuckettests 27.11% <ø> (ø)
integrationtests 58.42% <ø> (ø)
languageparsingtests 10.91% <ø> (ø)
localstacktests 21.45% <ø> (ø)
toolintegrationtests 30.42% <ø> (ø)
unit-tests_and_non-confidential-tests 28.81% <ø> (ø)
workflowintegrationtests 38.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen
Copy link
Member Author

(looks redundant with hotfix merged already)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@d 8F9A enis-yuen denis-yuen merged commit 2a618fa into develop Mar 14, 2024
@denis-yuen denis-yuen deleted the feature/param_version_openapi branch March 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@ll5zh ll5zh Awaiting requested review from ll5zh ll5zh was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @coverbeck @kathy-t
0