8000 Update ES index after updating AI topic by kathy-t · Pull Request #5856 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ES index after updating AI topic #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

Update ES index after updating AI topic #5856

merged 1 commit into from
Apr 1, 2024

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Mar 28, 2024 •
edited
Loading

Description
Follow-up to #5847 ...I forgot to update the entry's ElasticSearch index after uploading the topic so the new AI topics were not showing up on the search page without doing an entire re-index of ElasticSearch.

Review Instructions
See dockstore/dockstore-support#489

Issue
SEAB-6007

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Mar 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link
codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (9eef703) to head (c048ade).

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5856      +/-   ##
=============================================
- Coverage      74.52%   74.52%   -0.01%     
+ Complexity      5274     5273       -1     
=============================================
  Files            369      369              
  Lines          19055    19056       +1     
  Branches        2025     2025              
=============================================
  Hits           14201    14201              
  Misses          3893     3893              
- Partials         961      962       +1
Flag Coverage Δ
bitbuckettests 27.06% <0.00%> (-0.01%) ⬇️
integrationtests 58.55% <100.00%> (+<0.01%) ⬆️
languageparsingtests 11.00% <0.00%> (-0.01%) ⬇️
localstacktests 21.57% <0.00%> (-0.01%) ⬇️
toolintegrationtests 30.41% <0.00%> (-0.01%) ⬇️
unit-tests_and_non-confidential-tests 28.89% <0.00%> (-0.01%) ⬇️
workflowintegrationtests 38.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kathy-t kathy-t merged commit 08ff6f1 into develop Apr 1, 2024
@kathy-t kathy-t deleted the feature/seab-6007/index-entry-after-topic-update branch April 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@svonworl svonworl svonworl approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye

Assignees

@kathy-t kathy-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kathy-t @coverbeck @denis-yuen @svonworl
0