10000 fix unit for metric unload for calculated db load by denis-yuen · Pull Request #5876 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix unit for metric unload for calculated db load #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2024
Merged

fix unit for metric unload for calculated db load #5876

merged 2 commits into from
May 1, 2024

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Apr 30, 2024 •
edited
Loading

Description
Adds a unit for calculated database load (and other future ratio gauges)

Review Instructions
If you chart the metric after deployment in qa, it may show up as a percentage (upper left)
https://stackoverflow.com/questions/46711700/can-i-change-metric-units-on-cloudwatch

Issue
Follow-up for #5873

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Apr 30, 2024
@denis-yuen denis-yuen marked this pull request as ready for review April 30, 2024 21:29
@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye, svonworl, coverbeck and kathy-t and removed request for a team April 30, 2024 21:29
@codecov Codecov
Copy link
codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.57%. Comparing base (c0091ab) to head (d239475).

Files Patch % Lines
...ore/webservice/DockstoreWebserviceApplication.java 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5876      +/-   ##
=============================================
+ Coverage      64.15%   70.57%   +6.42%     
- Complexity      4627     5035     +408     
=============================================
  Files            371      371              
  Lines          19189    19190       +1     
  Branches        2005     2006       +1     
=============================================
+ Hits           12311    13544    +1233     
+ Misses          5906     4649    -1257     
- Partials         972      997      +25
Flag Coverage Δ
integrationtests 58.47% <66.66%> (+4.30%) ⬆️
languageparsingtests 11.07% <16.66%> (-0.01%) ⬇️
localstacktests 21.69% <66.66%> (-0.01%) ⬇️
toolintegrationtests 17.39% <16.66%> (-0.01%) ⬇️
unit-tests_and_non-confidential-tests 28.47% <66.66%> (+2.38%) ⬆️
workflowintegrationtests 38.65% <66.66%> (+7.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@denis-yuen denis-yuen merged commit 831453a into develop May 1, 2024
@denis-yuen denis-yuen deleted the feature/percent_unit_db_pool branch May 1, 2024 16:59
@denis-yuen denis-yuen mentioned this pull request May 2, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svonworl svonworl svonworl approved these changes

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denis-yuen @coverbeck @kathy-t @svonworl
0