8000
denis-yuen
requested review from
svonworl,
a team,
david4096 and
hyunnaye
and removed request for
a team
June 14, 2024 20:48
(Sonar) Fixed finding: "@Override should be used on overriding and implementing methods" #5907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementing methods"
|
This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App for source code. Free installation for Open Source projects: 👇 |
|
Probably need to work out something better for CircleCI and secrets, but this seems harmless enough and builds locally. |
denis-yuen
approved these changes
Jun 14, 2024
david4096
approved these changes
Jun 18, 2024
svonworl
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is
2EE0
closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation
This change fixes "
@Overrideshould be used on overriding and implementing methods" (id = java:S1161) identified by Sonar.Details
This change adds missing
@Overrideto known subclasses. Documenting inheritance will help readers and static analysis tools understand the code better, spot bugs easier, and in general lead to more efficient and effective review.Our changes look something like this:
interface AcmeParent { void doThing(); } class AcmeChild implements AcmeParent { + @Override void doThing() { thing(); } }More reading
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs | Codemod ID: sonar:java/add-missing-override-s1161