8000 Add conceptdoi to mocked Zenodo responses by kathy-t · Pull Request #5903 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add conceptdoi to mocked Zenodo responses #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add conceptdoi to mocked Zenodo responses #5903

merged 1 commit into from
Jun 3, 2024

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Jun 3, 2024

Description
Noticed some Zenodo hoverfly test failures in the develop branch. This PR fixes the tests by adding the conceptdoi property used in #5894 to the mocked Hoverfly responses. Also added a longer delay because I noticed one of the tests seemed flaky

Review Instructions
hoverfly-tests job should pass on CircleCI

Issue
n/a

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Jun 3, 2024
@kathy-t kathy-t marked this pull request as ready for review June 3, 2024 20:06
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link
codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (6370175) to head (744cd36).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5903      +/-   ##
=============================================
+ Coverage      71.27%   74.54%   +3.26%     
- Complexity      5178     5353     +175     
=============================================
  Files            374      374              
  Lines          19396    19396              
  Branches        2021     2021              
=============================================
+ Hits           13825    14459     +634     
+ Misses          4637     3969     -668     
- Partials         934      968      +34
Flag Coverage Δ
bitbuckettests 27.05% <ø> (ø)
hoverflytests 27.46% <ø> (?)
integrationtests 56.99% <ø> (ø)
languageparsingtests 11.10% <ø> (ø)
localstacktests 21.64% <ø> (ø)
toolintegrationtests 30.39% <ø> (ø)
unit-tests_and_non-confidential-tests 26.03% <ø> (ø)
workflowintegrationtests 38.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kathy-t kathy-t merged commit 74674f8 into develop Jun 3, 2024
19 checks passed
@kathy-t kathy-t deleted the feature/fix-zenodo-tests branch June 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-yuen denis-yuen denis-yuen approved these changes

@hyunnaye hyunnaye hyunnaye approved these changes

@coverbeck coverbeck Awaiting requested review from coverbeck

@svonworl svonworl Awaiting requested review from svonworl

Assignees

@kathy-t kathy-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kathy-t @denis-yuen @hyunnaye
0