8000 Try ignoring all python dependabot dependencies by david4096 · Pull Request #5928 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Try ignoring all python dependabot dependencies #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

Try ignoring all python dependabot dependencies #5928

merged 1 commit into from
Jul 3, 2024

Conversation

david4096
Copy link
Contributor
@david4096 david4096 commented Jul 2, 2024 •
edited
Loading

Description

We do not want dependabot updates for python dependencies in this repository. Simply removing the ecosystem from the .dependabot.yml didn't seem to work 600809d

https://github.com/dockstore/dockstore/security/dependabot/207

https://stackoverflow.com/questions/76756236/is-there-a-way-to-disable-dependabot-from-the-yaml-config

Review Instructions

Once merged, no more Python dependencies should show in https://github.com/dockstore/dockstore/security/dependabot

Issue

https://ucsc-cgl.atlassian.net/browse/SEAB-6514

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link
codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (e95b671) to head (f6c2a09).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #5928   +/-   ##
==========================================
  Coverage      74.33%   74.33%           
  Complexity      5369     5369           
==========================================
  Files            375      375           
  Lines          19432    19432           
  Branches        2031     2031           
==========================================
  Hits           14444    14444           
  Misses          4015     4015           
  Partials         973      973
Flag Coverage Δ
bitbuckettests 26.92% <ø> (ø)
hoverflytests 27.39% <ø> (ø)
integrationtests 56.85% <ø> (ø)
languageparsingtests 11.08% <ø> (ø)
localstacktests 21.59% <ø> (ø)
toolint 8000 egrationtests 30.31% <ø> (ø)
unit-tests_and_non-confidential-tests 25.97% <ø> (ø)
workflowintegrationtests 38.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david4096 david4096 merged commit 00baec3 into develop Jul 3, 2024
18 of 19 checks passed
@david4096 david4096 deleted the feature/seab-6514/python-deps branch July 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye

@kathy-t kathy-t Awaiting requested review from kathy-t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david4096 @coverbeck @denis-yuen
0