new linux machine executor with Java 21 #5961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damnit python && sam-cli! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5961 +/- ##
=============================================
- Coverage 74.24% 74.22% -0.03%
+ Complexity 5384 5383 -1
=============================================
Files 376 376
Lines 19505 19505
Branches 2035 2035
=============================================
- Hits 14481 14477 -4
- Misses 4050 4054 +4
Partials 974 974
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
tagging @david4096 because of the apt change, see also #5958 |
svonworl
approved these changes
Aug 7, 2024
scripts/install-tests.sh
Outdated
| @@ -13,7 +13,11 @@ fi | |||
| if [ "${TESTING_PROFILE}" = "regression-integration-tests" ]; then | |||
| pip3 install -r dockstore-webservice/src/main/resources/requirements/1.13.0/requirements3.txt | |||
| elif [ "${TESTING_PROFILE}" == "language-parsing-tests" ]; then | |||
| pip3 install -r dockstore-webservice/src/main/resources/requirements/1.14.0/requirements3.txt | |||
| #pip3 install -r dockstore-webservice/src/main/resources/requirements/1.14.0/requirements3.txt | |||
There was a problem hiding this comment.
Any reason to keep this line around (commented), rather than delete it completely?
There was a problem hiding this comment.
Will change to code comment to explain connection
coverbeck
approved these changes
Aug 7, 2024
kathy-t
approved these changes
Aug 8, 2024
|
svonworl
approved these changes
Aug 8, 2024
kathy-t
approved these changes
Aug 8, 2024
coverbeck
approved these changes
Aug 9, 2024
david4096
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try a new CircleCI machine with Java 21, this means our build environment for language parsing tests uses a VM that matches the jdk we expect to run at. Still, we're compiling to Java 17
Trade-offs:We'll finally be able to use Java 21 features, though we've been running in a Java 21 VM for quite a while, this will mean that our webservice jar is actually Java 21. Developers will need to use Java 21 locally, We gain a couple more years of support. see https://endoflife.date/oracle-jdkSplit out
Will probably be easier upgrading the dependent projects to Java 21 and then coming back than vice versa
Review Instructions
Builds should pass, qa should run.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6269
https://discuss.circleci.com/t/linux-machine-executor-2024-q2-update-including-cuda/50844
Security and Privacy
None
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation