8000 Update Surefire to non-milestone version by coverbeck · Pull Request #5981 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Surefire to non-milestone version #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Update Surefire to non-milestone version #5981

merged 3 commits into from
Jan 10, 2025

Conversation

coverbeck
Copy link
Collaborator
@coverbeck coverbeck commented Aug 22, 2024 •
edited
Loading

Description
Discovered in dockstore/swagger-java-zenodo-client#24 (comment)

Review Instructions
None. If it works, CI tests will pass, and if they work, the PR will be merged.

Issue
None

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck self-assigned this Aug 22, 2024
@coverbeck coverbeck mentioned this pull request Aug 22, 2024
Merged
9 tasks
@coverbeck
Copy link
Collaborator Author

Jeez, tests keep failing.

denis-yuen
denis-yuen approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member
@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense in principle, may need to add
https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failifnospecifiedtests
to the configuration

@coverbeck
Copy link
Collaborator Author

Makes sense in principle, may need to add https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failifnospecifiedtests to the configuration

Do you know off-hand why we have profiles with no specified tests? I can look at it more in detail if you don't know, but I wonder if it's flagging a legit issue.

@denis-yuen
Copy link
Member

Do you know off-hand why we have profiles with no specified tests? I can look at it more in detail if you don't know, but I wonder if it's flagging a legit issue.

If I had to guess, we have profiles for things like unit tests, hoverfly tests, non-confidential tests, but not all modules have the full set, so when a profile is set I would not be surprised if a particular module does not have any tests.
The weird part is that it seems like it should have occurred already.

But I do see that that module had no tests before, so maybe a regression?

[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ dockstore-language-plugin-parent ---
[INFO] No tests to run.

I think one thing to do is to set the flag and then see what the total number of unit tests recorded on Circle CI ends up being.

@denis-yuen
Copy link
Member

seems ready to merge, but not needed for 1.16 (barring conflict)

@coverbeck
Copy link
Collaborator Author

seems ready to merge, but not needed for 1.16 (barring conflict)

I keep meaning to double-check if this is a regression or not before merging. I don't think it is, that it is caused by a surefire update, and not that we stopped executing tests. In any case, I think this can wait.

@coverbeck coverbeck force-pushed the feature/surefireupdate branch from 69f238d to 1351d71 Compare January 9, 2025 17:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (2552462) to head (2115b02).
Report is 16 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #5981   +/-   ##
==========================================
  Coverage      74.41%   74.41%           
- Complexity      5632     5633    +1     
==========================================
  Files            386      386           
  Lines          20192    20192           
  Branches        2085     2085           
==========================================
+ Hits           15025    15026    +1     
  Misses          4167     4167           
+ Partials        1000      999    -1
Flag Coverage Δ
bitbuckettests 26.15% <ø> (+<0.01%) ⬆️
hoverflytests 27.62% <ø> (ø)
integrationtests 55.94% <ø> (ø)
languageparsingtests 10.83% <ø> (ø)
localstacktests 21.27% <ø> (ø)
toolintegrationtests 29.90% <ø> (ø)
unit-tests_and_non-confidential-tests 26.40% <ø> (ø)
workflowintegrationtests 37.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coverbeck coverbeck merged commit 01547d6 into develop Jan 10, 2025
24 checks passed
@coverbeck coverbeck deleted the feature/surefireupdate branch January 10, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-yuen denis-yuen denis-yuen approved these changes

@ka 5EAB thy-t kathy-t kathy-t approved these changes

@svonworl svonworl svonworl approved these changes

Assignees

@coverbeck coverbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coverbeck @denis-yuen @kathy-t @svonworl
0