8000 test with postgres 16.4 by denis-yuen · Pull Request #6063 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test with postgres 16.4 #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

test with postgres 16.4 #6063

merged 5 commits into from
Jan 9, 2025

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jan 6, 2025 •
edited
Loading

Description
Switch tests to postgres 16.4. Will be followed by changes to dockstore-deploy and test deployments on qa, staging, prod.

Review Instructions
I tested the DB doc build and ran docker compose as well as the tests themselves. Could probably do the first two.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6853
https://ucsc-cgl.atlassian.net/browse/SEAB-6875

Security and Privacy

None, this should address the linked tickets though

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 6, 2025
@denis-yuen
Copy link
Member Author
denis-yuen commented Jan 7, 2025 •
edited
Loading

Hmmm, no 16.6 image. May need to consider 17.0, but they also seem to be missing 17.1 and 17.2
CircleCI-Public/cimg-postgres#133

Edit to add:
Looks like 16.4 should buy us till September 2025 although AWS recommends 16.6 (which would be supported till March 2026).
Hopefully CircleCI will be more up-to-date by then https://docs.aws.amazon.com/AmazonRDS/latest/PostgreSQLReleaseNotes/postgresql-release-calendar.html

@codecov Codecov
Copy link
codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (2552462) to head (385e262).
Report is 10 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #6063   +/-   ##
==========================================
  Coverage      74.41%   74.41%           
- Complexity      5632     5633    +1     
==========================================
  Files            386      386           
  Lines          20192    20192           
  Branches        2085     2085           
==========================================
+ Hits           15025    15026    +1     
  Misses          4167     4167           
+ Partials        1000      999    -1
Flag Coverage Δ
bitbuckettests 26.15% <ø> (+<0.01%) ⬆️
hoverflytests 27.62% <ø> (ø)
integrationtests 55.94% <ø> (ø)
languageparsingtests 10.83% <ø> (ø)
localstacktests 21.27% <ø> (ø)
toolintegrationtests 29.90% <ø> (ø)
unit-tests_and_non-confidential-tests 26.40% <ø> (ø)
workflowintegrationtests 37.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen changed the title test with postgres 16.6 test with postgres 16.4 Jan 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@denis-yuen denis-yuen marked this pull request as ready for review January 7, 2025 18:28
@denis-yuen denis-yuen requested review from a team, kathy-t, hyunnaye and svonworl and removed request for a team January 7, 2025 18:28
@denis-yuen
Copy link
Member Author

Actually, I'm going to have to backport this to a hotfix, but will still merge this into develop

@denis-yuen denis-yuen mentioned this pull request Jan 7, 2025
Merged
9 tasks
@denis-yuen denis-yuen merged commit a4e0515 into develop Jan 9, 2025
24 checks passed
@denis-yuen denis-yuen deleted the feature/what_if_postgres_16 branch January 9, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathy-t kathy-t kathy-t approved these changes

@svonworl svonworl svonworl approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @kathy-t @svonworl
0