8000 update to newer dropwizard and logback by denis-yuen · Pull Request #6070 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update to newer dropwizard and logback #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

update to newer dropwizard and logback #6070

merged 1 commit into from
Jan 17, 2025

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jan 16, 2025 •
edited
Loading

Description
Logback CVE unblocked by new dropwizard version

Review Instructions
Dependabot CVE should go away, build on merge to develop should be fine

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6876

Security and Privacy

None

  • Security and Privacy assessed

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 16, 2025
@denis-yuen denis-yuen mentioned this pull request Jan 16, 2025
Merged
2 tasks
@codecov Codecov
Copy link
codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (fc4d73b) to head (f982a84).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #6070       +/-   ##
==============================================
+ Coverage      47.86%   74.43%   +26.56%     
- Complexity      3578     5636     +2058     
==============================================
  Files            386      386               
  Lines          20196    20196               
  Branches        2086     2086               
==============================================
+ Hits            9667    15033     +5366     
+ Misses          9581     4166     -5415     
- Partials         948      997       +49
Flag Coverage Δ
bitbuckettests 26.15% <ø> (?)
hoverflytests 27.57% <ø> (?)
integrationtests 55.96% <ø> (?)
languageparsingtests 10.83% <ø> (?)
localstacktests 21.26% <ø> (?)
toolintegrationtests 29.90% <ø> (+13.05%) ⬆️
unit-tests_and_non-confidential-tests 26.39% <ø> (+0.33%) ⬆️
workflowintegrationtests 37.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@denis-yuen denis-yuen marked this pull request as ready for review January 16, 2025 21:23
@denis-yuen denis-yuen requested review from a team, kathy-t, hyunnaye and svonworl and removed request for a team January 16, 2025 21:23
@denis-yuen denis-yuen merged commit 43541a2 into develop Jan 17, 2025
19 checks passed
@denis-yuen denis-yuen deleted the feature/logback_update branch January 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathy-t kathy-t kathy-t approved these changes

@svonworl svonworl svonworl approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @kathy-t @svonworl
0