8000 fix regression integration tests by denis-yuen · Pull Request #6072 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix regression integration tests #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2025
Merged

fix regression integration tests #6072

merged 5 commits into from
Feb 5, 2025

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jan 31, 2025 •
edited
Loading

Description
There were three issues with the regression tests. First, the cwltool install was failing on lxml (python pip). Second, the regression tests were not running on hotfix branches. Third, the regression tests were testing on a very old version.
This fixes those three issues.

Review Instructions
Could review next time we start a release branch for beta testing on staging or when distributing a new version for cli testing, etc. This also explains why I did this PR from by re-using an alpha release branch, this is one of the types of branches that run regression tests.
You're looking for an extra job on CircleCI, e.g. https://app.circleci.com/pipelines/github/dockstore/dockstore/11966/workflows/e3a0a0ca-fe53-4646-9225-a3680f3f6d14/jobs/50084

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6858

Security and Privacy

None, should be improvement if anything.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 31, 2025
@denis-yuen denis-yuen marked this pull request as ready for review January 31, 2025 16:23
@denis-yuen denis-yuen requested review from a team, kathy-t, hyunnaye and svonworl and removed request for a team January 31, 2025 16:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (2d8c858) to head (c06c948).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #6072      +/-   ##
=============================================
+ Coverage      74.44%   74.46%   +0.01%     
- Complexity      5637     5638       +1     
=============================================
  Files            386      386              
  Lines          20201    20201              
  Branches        2086     2086              
=============================================
+ Hits           15038    15042       +4     
+ Misses          4166     4162       -4     
  Partials         997      997
Flag Coverage Δ
bitbuckettests 26.16% <ø> (ø)
hoverflytests 27.60% <ø> (ø)
integrationtests 55.94% <ø> (-0.02%) ⬇️
languageparsingtests 10.86% <ø> (ø)
localstacktests 21.28% <ø> (ø)
regressionintegrationtests 22.67% <ø> (?)
toolintegrationtests 29.91% <ø> (ø)
unit-tests_and_non-confidential-tests 26.40% <ø> (ø)
workflowintegrationtests 37.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen merged commit a874ffb into develop Feb 5, 2025
21 checks passed
@denis-yuen denis-yuen deleted the release/1.17.0-alpha.2 branch February 5, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathy-t kathy-t kathy-t approved these changes

@hyunnaye hyunnaye hyunnaye approved these changes

@svonworl svonworl Awaiting requested review from svonworl svonworl was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @kathy-t @hyunnaye
0