8000 SEAB-6917: add Toil to Partner enum by hyunnaye · Pull Request #6073 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SEAB-6917: add Toil to Partner enum #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 7, 2025
Merged

SEAB-6917: add Toil to Partner enum #6073

merged 9 commits into from
Feb 7, 2025

Conversation

hyunnaye
Copy link
Contributor
@hyunnaye hyunnaye commented Feb 3, 2025 •
edited
Loading

Description
This PR adds Toil to the Partner enum

Review Instructions
See dockstore/dockstore-ui2#2058

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6917

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@hyunnaye hyunnaye self-assigned this Feb 3, 2025
@codecov Codecov
Copy link
codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (2d8c858) to head (860dd2c).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #6073      +/-   ##
=============================================
- Coverage      74.44%   74.42%   -0.02%     
+ Complexity      5637     5635       -2     
=============================================
  Files            386      386              
  Lines          20201    20202       +1     
  Branches        2086     2086              
=============================================
- Hits           15038    15035       -3     
- Misses          4166     4170       +4     
  Partials         997      997
Flag Coverage Δ
bitbuckettests 26.17% <100.00%> (+<0.01%) ⬆️
hoverflytests 27.61% <100.00%> (+<0.01%) ⬆️
integrationtests 55.94% <100.00%> (-0.02%) ⬇️
languageparsingtests 10.86% <100.00%> (+<0.01%) ⬆️
localstacktests 21.28% <100.00%> (+<0.01%) ⬆️
toolintegrationtests 29.91% <100.00%> (+<0.01%) ⬆️
unit-tests_and_non-confidential-tests 26.41% <100.00%> (+<0.01%) ⬆️
workflowintegrationtests 37.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kathy-t
kathy-t approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor
@kathy-t kathy-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket has 1.16.x milestone, should this and the UI PR go to the hotfix branch?

@hyunnaye hyunnaye merged commit ee0bee5 into develop Feb 7, 2025
20 checks passed
@hyunnaye hyunnaye deleted the feature/SEAB-6917 branch February 7, 2025 17:56
hyunnaye added a commit that referenced this pull request Feb 10, 2025
@hyunnaye
SEAB-6917: add Toil to Partner enum (#6073) 
* add Toil to enum

* test

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build
hyunnaye added a commit that referenced this pull request Feb 11, 2025
@hyunnaye
SEAB-6917: add Toil to Partner enum (#6073) (#6077)
5bde580 
* add Toil to enum

* test

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build

* try to see if this fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathy-t kathy-t kathy-t approved these changes

@svonworl svonworl svonworl approved these changes

@denis-yuen denis-yuen Awaiting requested review from denis-yuen

Assignees

@hyunnaye hyunnaye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyunnaye @kathy-t @svonworl
0