8000 Put back reusable deploy workflow by kathy-t · Pull Request #6080 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Put back reusable deploy workflow #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2025
Merged

Put back reusable deploy workflow #6080

merged 5 commits into from
Feb 27, 2025

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Feb 26, 2025 •
edited
Loading

Description
When we merged 1.16.4 into develop (commit), it accidentally reverted #6054 which put back the reusable deploy workflow.

This PR puts back the reusable deploy_artifacts workflow that was introduced in #6043 and reinstated in #6054. This PR really just cherry picks #6054 with the addition of adding workflow_dispatch so it can be called in the GitHub Actions UI as a backup.

The old tagged_release workflow is still there as a backup and for use in 1.16.x releases. I will create a ticket to remove it in 1.18.

  • Note that the manual copying of the image digest to the dockstore-webservice folder is still required for 1.16.x releases. This is because the tagged_release workflow in the master branch does NOT copy it to the dockstore-webservice folder.
  • The reusable deploy workflow in this PR will not run in 1.16.x releases because it does not exist in master.
  • So for a new 1.16.x release, you would manually run the tagged_release workflow then copy the image digest to the dockstore-webservice folder in S3. This step will go away for 1.17 because we have the reusable deploy workflow.

Review Instructions
Create a branch, commit a change and push it. Go to GitHub Actions tab and verify that the Deploy Artifacts workflow runs successfully. Do the same for a tag.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6916

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Feb 26, 2025
@codecov Codecov
Copy li 8000 nk
codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (03f8ca5) to head (f22ce37).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #6080   +/-   ##
==========================================
  Coverage      74.41%   74.41%           
  Complexity      5639     5639           
==========================================
  Files            386      386           
  Lines          20206    20206           
  Branches        2088     2088           
==========================================
  Hits           15037    15037           
  Misses          4170     4170           
  Partials         999      999
Flag Coverage Δ
bitbuckettests 26.16% <ø> (-0.01%) ⬇️
hoverflytests 27.63% <ø> (ø)
integrationtests 55.94% <ø> (ø)
languageparsingtests 10.86% <ø> (ø)
localstacktests 21.28% <ø> (ø)
toolintegrationtests 29.91% <ø> (ø)
unit-tests_and_non-confidential-tests 26.41% <ø> (ø)
workflowintegrationtests 37.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@denis-yuen
Copy link
Member
denis-yuen commented Feb 27, 2025 •
edited by kathy-t
Loading

So for a new 1.16.x release, you would manually run the tagged_release workflow then copy the image digest to the dockstore-webservice folder in S3. This step will go away for 1.17 because we have the reusable deploy workflow.

Could you add this somewhere in the release checklists for 1.16.x (if not already)?

@kathy-t
Copy link
Contributor Author
kathy-t commented Feb 27, 2025 •
edited
Loading

So for a new 1.16.x release, you would manually run the tagged_release workflow then copy the image digest to the dockstore-webservice folder in S3. This step will go away for 1.17 because we have the reusable deploy workflow.

Could you add this somewhere in the release checklists for 1.16.x (if not already)?

It's part of the 1.16.6 prod checklist under Versions https://github.com/dockstore/dockstore-deploy/wiki/1.16.6-prod-checklist, which is linked at the wiki Home page https://github.com/dockstore/dockstore-deploy/wiki

@kathy-t kathy-t merged commit 9615f48 into develop Feb 27, 2025
24 checks passed
7F8C
@kathy-t kathy-t deleted the feature/seab-6916/reusable-deploy branch February 27, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-yuen denis-yuen denis-yuen approved these changes

@hyunnaye hyunnaye hyunnaye approved these changes

@svonworl svonworl svonworl approved these changes

Assignees

@kathy-t kathy-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kathy-t @denis-yuen @hyunnaye @svonworl
0