8000 Return 404 if tooltester logs don't exist in S3 by kathy-t · Pull Request #6128 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Return 404 if tooltester logs don't exist in S3 #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Return 404 if tooltester logs don't exist in S3 #6128

merged 1 commit into from
Jul 3, 2025

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Jul 3, 2025 •
edited
Loading

Description
This PR catches the NoSuchKeyException that is thrown when a tooltester key doesn't exist in S3 and returns a 404 to the user.

Review Instructions
I think the tooltester logs are only set up in prod so wait for a prod deploy to review. Follow the instructions in the issue and verify that a 404 is returned instead of a 503

Issue
#5983
https://ucsc-cgl.atlassian.net/browse/DOCK-2572

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Jul 3, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jul 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (5e24f6c) to head (04d72d1).

Files with missing lines Patch % Lines
...store/webservice/resources/ToolTesterResource.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##             hotfix/1.17.1    #6128      +/-   ##
===================================================
- Coverage            74.22%   74.17%   -0.06%     
+ Complexity            5664     5661       -3     
===================================================
  Files                  389      389              
  Lines                20334    20337       +3     
  Branches              2101     2101              
===================================================
- Hits                 15093    15085       -8     
- Misses                4238     4249      +11     
  Partials              1003     1003
Flag Coverage Δ
bitbuckettests 25.93% <0.00%> (-0.01%) ⬇️
hoverflytests 27.62% <0.00%> (-0.01%) ⬇️
integrationtests 56.07% <0.00%> (-0.01%) ⬇️
languageparsingtests 10.82% <0.00%> (-0.01%) ⬇️
localstacktests 21.33% <0.00%> (-0.01%) ⬇️
regressionintegrationtests ?
toolintegrationtests 29.90% <0.00%> (-0.01%) ⬇️
unit-tests_and_non-confidential-tests 26.31% <0.00%> (-0.01%) ⬇️
workflowintegrationtests 37.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kathy-t kathy-t requested review from denis-yuen and svonworl July 3, 2025 15:36
@kathy-t kathy-t merged commit e788ccd into hotfix/1.17.1 Jul 3, 2025
22 of 24 checks passed
@kathy-t kathy-t deleted the 5983/404-tooltester branch July 3, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-yuen denis-yuen denis-yuen approved these changes

@svonworl svonworl svonworl approved these changes

Assignees

@kathy-t kathy-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kathy-t @denis-yuen @svonworl
0