Fix cache storage related test issues (due to doctrine/cache 1.5.0 changes) #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrine/cache@dd47003 removes the 'DoctrineNamespaceCacheKey[]' entry from the cache. Thus, all tests counting cache entries were off by one.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3908 We use Jira to track the state of pull requests and the versions they got |
|
@mpdude thanks! I'll probably have to bump the dependency to |
Ocramius
added a commit
that referenced
this pull request
Sep 19, 2015
…ineNamespaceCacheKey Fix tests
Ocramius
pushed a commit
that referenced
this pull request
Sep 19, 2015
Backports #1510 Fixes DDC-3908 doctrine/cache@dd47003 removes the 'DoctrineNamespaceCacheKey[]' entry from the cache. Thus, all tests counting cache entries were off by one.
Ocramius
added a commit
that referenced
this pull request
Sep 19, 2015
|
Backported into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/cache@dd47003 removes the
DoctrineNamespaceCacheKey[]entry from the cache. Thus, all tests counting cache entries were off by one.