8000 Test for array of enums by ThomasLandauer · Pull Request #10111 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test for array of enums #10111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Test for array of enums #10111

wants to merge 8 commits into from

Conversation

ThomasLandauer
Copy link
Contributor

As requested in #10063

I'm not sure if this is really testing anything, since (I think) it passes in 2.13.2 too. Could you please double-check?

Are PHP attributes (mapping information) not available in tests?

@ThomasLandauer ThomasLandauer mentioned this pull request Oct 7, 2022
Closed
@derrabus
Copy link
Member
derrabus commented Oct 7, 2022

You need to make sure the test is not executed on PHP 8.0 and below. Especially the enum must not be parsed on older PHP versions.

@ThomasLandauer
Copy link
Contributor Author

Sorry, where can I configure this?

@greg0ire
Copy link
Member
greg0ire commented Oct 8, 2022

You can use @requires, like so:

orm/tests/Doctrine/Tests/ORM/ORMSetupTest.php

Lines 53 to 55 in b2a4fac

/**
* @requires PHP 8.0
*/

greg0ire
greg0ire reviewed Oct 8, 2022
View reviewed changes
greg0ire
greg0ire reviewed Oct 8, 2022
View reviewed changes
@greg0ire
Copy link
Member
greg0ire commented Oct 8, 2022

Looks better, doesn't it? 🙂

Do you need help with the remaining issues?

@greg0ire greg0ire enabled auto-merge (squash) October 8, 2022 15:49
@greg0ire greg0ire requested a review from derrabus October 8, 2022 15:49
@derrabus
Copy link
Member
derrabus commented Oct 9, 2022

The test looks okay, but does it really cover the issue that was introduced with 2.13.2? I would've expected the use of a query builder to reproduce the problem.

@michnovka
Copy link
Contributor

I think these tests are redundant now, they are part of #10058 . see:
https://github.com/HypeMC/orm/blob/d69a0fa2cfd3b883200a6324829945509f4ecc07/tests/Doctrine/Tests/ORM/Functional/EnumTest.php#L100

@michnovka michnovka mentioned this pull request Oct 11, 2022
Closed
@ThomasLandauer
Copy link
Contributor Author

Sorry guys, I wasn't sure from the beginning what I'm supposed to do in this test; and I know even less now ;-) So please somebody take over, or just close...

@derrabus
Copy link
Member

Okay, let's close this PR then.

@derrabus derrabus closed this Mar 13, 2023
auto-merge was automatically disabled March 13, 2023 10:01

Pull request was closed

@ThomasLandauer ThomasLandauer deleted the patch-1 branch March 13, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire left review comments

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasLandauer @derrabus @greg0ire @michnovka
0