8000 BUG: When changing SQLFilter parameter, resulting SQL query is not generated correctly by dbannik · Pull Request #11694 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BUG: When changing SQLFilter parameter, resulting SQL query is not generated correctly #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

BUG: When changing SQLFilter parameter, resulting SQL query is not generated correctly #11694

merged 1 commit into from
Oct 23, 2024

Conversation

dbannik
Copy link
Contributor
@dbannik dbannik commented Oct 22, 2024 •
edited
Loading

Is not correctly generated sql when changed/switched sqlFilter parameters

CachedPersisterContext::$selectJoinSql should be clear or regenerated when sqlFilter changed

The problem reproduce when in use fetch=EAGER and use additional sql filter on this property

@dbannik dbannik force-pushed the Bug-join-sql-when-change-sqlFilter-parameters branch from 6d81376 to b3735ef Compare October 22, 2024 16:22
@dbannik dbannik marked this pull request as ready for review October 22, 2024 16:28
@greg0ire
Copy link
Member

Please improve your commit message according to the contributing guide.

Most notably, please describe the bug, and explain how your changes address the issue.

@dbannik dbannik force-pushed the Bug-join-sql-when-change-sqlFilter-parameters branch 2 times, most recently from daad5e4 to 3717654 Compare October 22, 2024 19:32
@dbannik dbannik requested a review from greg0ire October 22, 2024 19:36
greg0ire
greg0ire previously approved these changes Oct 22, 2024
View reviewed changes
@dbannik dbannik force-pushed the Bug-join-sql-when-change-sqlFilter-parameters branch from 3717654 to 210ba6e Compare October 22, 2024 19:46
@dbannik dbannik requested a review from greg0ire October 22, 2024 20:19
SenseException
SenseException previously approved these changes Oct 22, 2024
View reviewed changes
@greg0ire
Copy link
Member

🤔 why is this targeting 2.21.x?

@dbannik
Copy link
Contributor Author
dbannik commented Oct 23, 2024

@greg0ire I don't know which branch to merge into
in my case, in version 2.19 and higher, this problem is present

@greg0ire
Copy link
Member

Take a look at #11208

@dbannik
Is not correctly generated sql when changed/switched sqlFilter parame…
439b4da 
…ters

CachedPersisterContext::$selectJoinSql should be clear or regenerated when sqlFilter changed
The problem reproduce when in use fetch=EAGER and use additional sql filter on this property
@dbannik dbannik force-pushed the Bug-join-sql-when-change-sqlFilter-parameters branch from 210ba6e to 439b4da Compare October 23, 2024 09:05
@dbannik dbannik changed the base branch from 2.21.x to 2.20.x October 23, 2024 09:05
@dbannik dbannik dismissed SenseException’s stale review October 23, 2024 09:05

The base branch was changed.

dbannik added a commit to dbannik/orm that referenced this pull request Oct 23, 2024
@dbannik
doctrine#11694 - update to 4.0.x
5df2f9f
dbannik added a commit to dbannik/orm that referenced this pull request Oct 23, 2024
@dbannik
doctrine#11694 - update to 3.3.x
328f401
@dbannik dbannik mentioned this pull request Oct 23, 2024
Closed
@dbannik
Copy link
Contributor Author
dbannik commented Oct 23, 2024

@greg0ire I sent it to 2.20 and prepared fixes #11695 for 3.3 and higher

dbannik added a commit to dbannik/orm that referenced this pull request Oct 23, 2024
@dbannik
doctrine#11694 - update to 3.3.x
6a25058
dbannik added a commit to dbannik/orm that referenced this pull request Oct 23, 2024
@dbannik
doctrine#11694 - update to 3.3.x
69ef7f8
@greg0ire greg0ire added this to the 2.20.1 milestone Oct 23, 2024
@greg0ire greg0ire merged commit 3ca9529 into doctrine:2.20.x Oct 23, 2024
75 checks passed
@greg0ire
Copy link
Member

Thanks @dbannik !

@dbannik dbannik deleted the Bug-join-sql-when-change-sqlFilter-parameters branch October 23, 2024 19:35
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
@bobvandevijver bobvandevijver mentioned this pull request Jan 7, 2025
Closed
dbannik pushed a commit to dbannik/orm that referenced this pull request Jan 17, 2025
@bobvandevijver @dbannik
Fix Hydration when use ManyToMany[indexBy]
43d33aa 
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
dbannik pushed a commit to dbannik/orm that referenced this pull request Jan 19, 2025
@bobvandevijver @dbannik
Fix Hydration when use ManyToMany[indexBy]
47a3015 
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
@greg0ire greg0ire mentioned this pull request Jan 20, 2025
Merged
dbannik pushed a commit to dbannik/orm that referenced this pull request Jan 21, 2025
@bobvandevijver @dbannik
Fix Hydration when use ManyToMany[indexBy]
2b62d35 
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
dbannik pushed a commit to dbannik/orm that referenced this pull request Jan 27, 2025
@bobvandevijver @dbannik
Fix Hydration when use ManyToMany[indexBy]
6755bb0 
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
@dbannik dbannik mentioned this pull request May 5, 2025
Closed
dbannik added a commit to dbannik/orm that referenced this pull request May 5, 2025
@dbannik
doctrine#11931 Bug when change sql filter [Related issue doctrine#11694]
e1f8ed4 
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik added a commit to dbannik/orm that referenced this pull request May 5, 2025
@dbannik
doctrine#11931 Bug when change sql filter [Related issue doctrine#11694]
841d7e8 
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik added a commit to dbannik/orm that referenced this pull request May 5, 2025
@dbannik
doctrine#11931 Bug when change sql filter [Related issue doctrine#11694]
0517127 
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik added a commit to dbannik/orm that referenced this pull request May 5, 2025
@dbannik
doctrine#11931 Bug when change sql filter [Related issue doctrine#11694]
e172b3b 
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
greg0ire added a commit that referenced this pull request May 6, 2025
@greg0ire
Merge pull request #11932 from dbannik/2.20.3-issue-11931
ae2957c 
#11931 Bug when change sql filter [Related issue #11694]
rotdrop added a commit to rotdrop/orm that referenced this pull request May 15, 2025
@rotdrop
Fix index one-to-many association.
0ca2bcf 
Previously, new aliases were allocated for each association, but the
index-by cache would just pick the first alias ever used. Fix this but
not allocating a new alias for an already used join-column. See also:

commit 6755bb0
Author: Bob van de Vijver <bobvandevijver@hotmail.com>
Date:   Wed Jan 8 10:38:23 2025 +0100

    Fix Hydration when use ManyToMany[indexBy]

    The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
    invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop added a commit to rotdrop/orm that referenced this pull request May 31, 2025
@rotdrop
Fix index one-to-many association.
066d287 
Previously, new aliases were allocated for each association, but the
index-by cache would just pick the first alias ever used. Fix this but
not allocating a new alias for an already used join-column. See also:

commit 6755bb0
Author: Bob van de Vijver <bobvandevijver@hotmail.com>
Date:   Wed Jan 8 10:38:23 2025 +0100

    Fix Hydration when use ManyToMany[indexBy]

    The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
    invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop added a commit to rotdrop/orm that referenced this pull request Jun 24, 2025
@rotdrop
Fix index one-to-many association.
acdaa77 
Previously, new aliases were allocated for each association, but the
index-by cache would just pick the first alias ever used. Fix this but
not allocating a new alias for an already used join-column. See also:

commit 6755bb0
Author: Bob van de Vijver <bobvandevijver@hotmail.com>
Date:   Wed Jan 8 10:38:23 2025 +0100

    Fix Hydration when use ManyToMany[indexBy]

    The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and
    invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.20.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dbannik @greg0ire @SenseException @savemetenminutes
0