8000 Update message of `ORMInvalidArgumentException` by lacatoire · Pull Request #11845 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update message of ORMInvalidArgumentException #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

Update message of ORMInvalidArgumentException #11845

merged 2 commits into from
Mar 24, 2025

Conversation

lacatoire
Copy link
Contributor

update message to use attribute instead of annotation

@lacatoire
Update ORMInvalidArgumentException.php
3aed691 
update message to use attribute instead of annotation
@derrabus derrabus added this to the 2.20.3 milestone Feb 21, 2025
@derrabus derrabus changed the title Update ORMInvalidArgumentException.php Update message of ORMInvalidArgumentException Feb 21, 2025
derrabus
derrabus previously requested changes Feb 21, 2025
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to escape the quotes in the exception message.

@lacatoire
Copy link
Contributor Author

Escaped

@greg0ire
Copy link
Member

You will need to update the tests as well.

@greg0ire greg0ire force-pushed the update-message-annotation-to-attribute branch from 121c3d6 to 2d2a344 Compare March 23, 2025 15:08
@greg0ire greg0ire dismissed derrabus’s stale review March 24, 2025 09:57

The requested changes have been applied

@greg0ire greg0ire merged commit 44057b4 into doctrine:2.20.x Mar 24, 2025
74 checks passed
@greg0ire
Copy link
Member

Thanks @lacatoire !

@lacatoire lacatoire deleted the update-message-annotation-to-attribute branch March 24, 2025 10:10
@github-actions github-actions bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.20.3
Development

Successfully merging this pull request may close these issues.
4 participants
@lacatoire @greg0ire @SenseException @derrabus
0