8000 add capability to use allfields sql notation by eltharin · Pull Request #11846 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add capability to use allfields sql notation #11846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

add capability to use allfields sql notation #11846

merged 1 commit into from
May 8, 2025

Conversation

eltharin
Copy link
Contributor
@eltharin eltharin commented Feb 21, 2025 •
edited
Loading

in a dto, this PR allow to call u.* to get all fileds fo u entity in one call,

need #11825 to work

@eltharin eltharin force-pushed the all_fields branch 6 times, most recently from 1badf98 to 038734f Compare March 19, 2025 15:19
greg0ire
greg0ire reviewed Mar 20, 2025
View reviewed changes
greg0ire
greg0ire reviewed Mar 20, 2025
View reviewed changes
@eltharin
add capability to use allfields sql notation
12c721f 
in a dto, this PR allow to call u.* to get all fileds fo u entity in one call,
@eltharin eltharin requested a review from greg0ire May 4, 2025 07:26
@greg0ire greg0ire added this to the 3.4.0 milestone May 8, 2025
@greg0ire greg0ire merged commit 083b241 into doctrine:3.4.x May 8, 2025
86 checks passed
@greg0ire
Copy link
Member
greg0ire commented May 8, 2025

Thanks @eltharin !

@github-actions github-actions bot mentioned this pull request Jun 14, 2025
Merged
@eltharin eltharin deleted the all_fields branch June 17, 2025 08:18
@greg0ire
Copy link
Member

We are going to revert this because, to quote @beberlei

  • " it adds alias.* which is not possible in any other place, for example you cannot do SELECT u.* FROM User u"
  • "its fundamently broken imho, what if you change the property oder in mapping fields? that effects the result here and breaks code. its too much coupling imho between things that are not related"

@eltharin eltharin mentioned this pull request Jun 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eltharin @greg0ire @SenseException
0