8000 Fix non-deterministic test by mbeccati · Pull Request #11866 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix non-deterministic test #11866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix non-deterministic test #11866

merged 1 commit into from
Mar 13, 2025

Conversation

mbeccati
Copy link
Contributor

I've got a random test failure on my CI, which led me to the discovery that the test is missing ORDER BYs to make it deterministic.

1) Doctrine\Tests\ORM\Functional\QueryTest::testModifiedLimitQuery
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'gblanco1'
+'gblanco0'

/.../tests/Tests/ORM/Functional/QueryTest.php:567

@SenseException SenseException merged commit 3303cd3 into doctrine:2.20.x Mar 13, 2025
71 checks passed
@SenseException
Copy link
Member

Thank you @mbeccati

@mbeccati mbeccati deleted the fix-unordered-test branch March 14, 2025 17:10
@greg0ire greg0ire added this to the 2.20.3 milestone May 2, 2025
@github-actions github-actions bot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
2.20.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mbeccati @SenseException @greg0ire
0