favor Table::addPrimaryKeyConstraint() over Table::setPrimaryKey() #11882
Conversation
|
tests were already failing before on the |
There was a problem hiding this comment.
Thanks @xabbuh!
I'd be nice merging these PRs ASAP to help make the Symfony CI green again 🙏
src/Tools/SchemaTool.php
Outdated
| @@ -282,7 +286,17 @@ public function getSchemaFromMetadata(array $classes): Schema | |||
| } | |||
|
|
|||
| if ($pkColumns !== []) { | |||
| $table->setPrimaryKey($pkColumns); | |||
| if (class_exists(PrimaryKeyConstraint::class)) { | |||
There was a problem hiding this comment.
Can you factor this method out? its repeated three times.
There was a problem hiding this comment.
done, not sure though how I can satisfy PHPStan
There was a problem hiding this comment.
I think you have to add more lines under
Line 16 in f3fb796
ab75661 to
f3620b4
Compare
f3620b4 to
c55f10e
Compare
@xabbuh @nicolas-grekas tell me if I'm wrong, but I think Symfony is deliberately using dev dependencies, including for Doctrine because of Doctrine Bridge (typically, to address deprecations before they hit end users). |
|
@greg0ire correct. This allows spotting changes as early as possible: bugs, deprecations, etc. And makes adopting new versions of Doctrine way smoother. |
see doctrine/dbal#6867