8000 do not use deprecated primary key constraint features by xabbuh · Pull Request #11903 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

do not use deprecated primary key constraint features #11903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

do not use deprecated primary key constraint features #11903

merged 1 commit into from
Apr 23, 2025

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 15, 2025

related to doctrine/dbal#6867

@xabbuh xabbuh force-pushed the dbal-6867 branch 2 times, most recently from 6d5ce47 to 23d676f Compare April 15, 2025 06:57
@xabbuh xabbuh changed the title do not call isPrimary() with DBAL 4.3, check for PrimaryKeyConstraint instead do not use deprecated primary key constraint features Apr 22, 2025
@xabbuh xabbuh force-pushed the dbal-6867 branch 4 times, most recently from 8a6c9d1 to 766898d Compare April 22, 2025 10:13
@xabbuh xabbuh marked this pull request as ready for review April 22, 2025 10:33
greg0ire
greg0ire previously approved these changes Apr 22, 2025
View reviewed changes
morozov
morozov previously approved these changes Apr 22, 2025
View reviewed changes
SenseException
SenseException previously approved these changes Apr 22, 2025
View reviewed changes
@xabbuh xabbuh dismissed stale reviews from SenseException, morozov, and greg0ire via 6675a02 April 23, 2025 04:59
@greg0ire greg0ire added this to the 3.3.3 milestone Apr 23, 2025
@greg0ire greg0ire merged commit 28575f5 into doctrine:3.3.x Apr 23, 2025
84 checks passed
@greg0ire
Copy link
Member

Thanks @xabbuh !

@xabbuh xabbuh deleted the dbal-6867 branch April 23, 2025 05:58
@xabbuh xabbuh mentioned this pull request May 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@morozov morozov morozov left review comments

@SenseException SenseException SenseException left review comments

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @greg0ire @morozov @SenseException
0