Deprecate more proxies-related methods or calls #12020
Conversation
| 'Passing anything but null as $proxyDir to %s is deprecated and will not be possible in Doctrine ORM 3.0.', | ||
| __METHOD__, | ||
| ); | ||
| } |
There was a problem hiding this comment.
@derrabus @SenseException one way to be forward-compatible with the desired signature (one that omits $proxyDir while still specifying a cache is to use named arguments, but I haven't find a way to enforce that, so right now, I'm just deprecating passing null.
Do you know of a way to detect if $proxyDir was used (even with null)?
If not, then maybe I should create new methods like createAttributeMetadataConfig that do not have that argument and deprecate the Configuration-suffixed methods in favor of the Config-suffixed ones?
I have also considered doing some kind of CacheItemPoolInterface|string|null $proxyDirOrCache - based horror, but with named, arguments, that's a breaking change.
WDYT?
There was a problem hiding this comment.
I will create a dedicated PR shortly with the "new methods" solution. In the meantime, let's merge this.
…n available (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge] use native lazy objects on PHP 8.4+ when available | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT following the changes from doctrine/orm#12005 and doctrine/orm#12020 Commits ------- 1256ce9 use native lazy objects on PHP 8.4+ when available
No description provided.