Exception Call to undefined method Doctrine\Common\Cache\MemcachedCache::setMemcache() #6971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, this was introduced in #6905 in order to keep Memcache(d)/APC(u) working on PHP 7.1+; sorry for that. |
|
Hey there! Our app also got hit by the change introduced in #6905. Seems like the build failures are due to timeouts, would it be possible to re-trigger and get this merged? |
|
Restarted it. |
|
@rolando-caldas this should go to branch |
…he::setMemcache() When memcached extension is loaded Doctrine\ORM\Tools\Setup.php calls to setMemcache method. The MemcachedCache class has the setMemcached method instead. Changed this call in Setup to setMemcached and $memcache to $memcached to keep the name like the extension
lcobucci
approved these changes
Jan 30, 2018
Majkl578
approved these changes
Jan 30, 2018
|
@rolando-caldas 🚢 thanks! |
|
Manually merged on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing Doctrine CLI:
doctrine orm:schema-tool:createand with memcached extension loaded, Doctrine\ORM\Tools\Setup.php calls to setMemcache method. The MemcachedCache class has the setMemcached method instead. Changed this call in Setup to setMemcached and $memcache to $memcached to keep the name like the extension