8000 Update getting-started.rst by Stanzi1791 · Pull Request #7420 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update getting-started.rst #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update getting-started.rst #7420

wants to merge 2 commits into from

Conversation

Stanzi1791
Copy link
@Stanzi1791 Stanzi1791 commented Oct 7, 2018

I propose "doctrine/orm": "2.4.*", is changed to "doctrine/orm": "*", in the example JSON file at the start of the Getting Started with Doctrine tutorial.

Without the change, I got a missing AnnotationFactory.php class error when running the orm:schema-tool:create command, and changing it to "*" fixed that for me.

I propose "doctrine/orm": "2.4.*", is changed to "doctrine/orm": "*", in the example JSON file at the start of this tutorial.

Without the change, I got a missing AnnotationFactory class error when running the "orm:schema-tool:create" command, and changing it to "*" fixed that for me.
@Majkl578
Copy link
Contributor
Majkl578 commented Oct 8, 2018

Using * constraint is wrong as it would allow ORM 3.0 (when released) and break your application.
But you're correct that 2.4.* is wrong too, it should be ^2.6 - can you use that instead of "*"?
Thanks.

@Ocramius
Copy link
Member
Ocramius commented Oct 8, 2018 via email

@Stanzi1791
Copy link
Author

Changed to ^2.6.

@Majkl578
Copy link
Contributor

Hi, sorry for bad news - #7412 got merged yesterday and it changed the constraint to ^2.6.2 so this PR is now redundant. :/ But thank you anyway. 👍

@Majkl578 Majkl578 closed this Nov 11, 2018
@Majkl578 Majkl578 self-assigned this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
3084
0