Improve templating #9541
Merged
Improve templating #9541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Feb 22, 2022
| @@ -14,58 +15,93 @@ | |||
| use function assert; | |||
| use function is_string; | |||
| use function is_subclass_of; | |||
| use function sprintf; | |||
|
|
|||
| /** | |||
| * @internal | |||
There was a problem hiding this comment.
This allows me to do all sorts of BC-breaks.
|
The drop in coverage looks too high to be realistic. Let me write some tests and try again, to see how it affects the coverage. |
e8f31ec to
bb1a72b
Compare
Maybe that's the issue… this is a 1-week old ancestor of 2.12.x EDIT: looks like my commit was based on that commit, and I just needed to rebase lol |
bb1a72b to
521fd5f
Compare
|
The codecov comments seem to relate to a bad handling of multiline expressions. When I try using <line nr="68">
<covered by="Doctrine\Tests\ORM\Mapping\AttributeReaderTest::testItThrowsWhenGettingRepeatableAnnotationWithTheWrongMethod"/>
</line>
<line nr="74">
|
derrabus
reviewed
Feb 24, 2022
521fd5f to
7034287
Compare
derrabus
reviewed
Feb 24, 2022
Comment on lines
29
to
31
| /** | ||
| * @requires PHP 8.0 | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @requires PHP 8.0 | |
| */ |
|
LGTM Please merge, once the redundant doc block that I commented on is removed. 🙂 |
This is helpful for static analysis
7034287 to
40af1fc
Compare
derrabus
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #9528, which was getting bigger and bigger, I noticed some improvements that I feel deserve a separate PR, given the complexity.