-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Adding PHP attributes #9555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adding PHP attributes #9555
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2f7c73a
Adding PHP attributes
ThomasLandauer 9a0f32a
Update docs/en/reference/basic-mapping.rst
ThomasLandauer 77ee291
Update basic-mapping.rst
ThomasLandauer ede5055
Update basic-mapping.rst
ThomasLandauer 0e4b577
Update basic-mapping.rst
ThomasLandauer a303cc8
Update basic-mapping.rst
ThomasLandauer 208e284
Update docs/en/reference/basic-mapping.rst
ThomasLandauer 2dfffd0
Update docs/en/reference/basic-mapping.rst
ThomasLandauer 4ef8d07
Update docs/en/reference/basic-mapping.rst
ThomasLandauer d116f60
Adding missing `use Doctrine\ORM\Mapping\Table;` and ` use Doctrine\…
ThomasLandauer 9e986bb
Adding another `use`
ThomasLandauer c1af52a
Adding `versionadded`
ThomasLandauer 01deae2
Update docs/en/reference/basic-mapping.rst
ThomasLandauer ba73be1
Update docs/en/reference/basic-mapping.rst
ThomasLandauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I commented on your commit where you mentioned me, isn't this going to break syntactic coloration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's the same as I was using at https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/events.html#lifecycle-callbacks
Sorry about the mentioning! Somebody already told me that before - I hope I'll remember next time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, please reword that commit to make it go away.
How to do that?
git rebase -i origin/2.11.x
, assumingorigin
is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, rungit remote -vvv
, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.pick
withreword
on the line corresponding to your commitgit push --force
to overwrite what you already push. Don't forget the--force
option otherwise git will try to merge both things together.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, my "Git instructor"! :-) It looks like I succeeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, great job! My inbox thanks you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is resolved? Could you please merge it then?