Deprecate calling setters without arguments #9791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
greg0ire
reviewed
May 29, 2022
21c2baa to
1c8e9b9
Compare
greg0ire
approved these changes
May 30, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
May 30, 2022
* 2.13.x: Add missing import (doctrine#9796) Deprecate calling setters without arguments (doctrine#9791) Move duplicate fixture into dedicated file (doctrine#9789) MockTreeWalker should be an SqlWalker (doctrine#9790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a setter without anything to set does not really make sense semantically. However, declaring
nullas the default value for a parameter used to be a common workaround to get a nullable typed parameter. This workaround is obsolete since PHP 7.1 introduced actual nullable types.This is why I'd like to get rid of those default values on setters.