8000 Regenerate Psalm baseline by derrabus · Pull Request #9135 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Regenerate Psalm baseline #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Regenerate Psalm baseline #9135

merged 1 commit into from
Oct 20, 2021

Conversation

derrabus
Copy link
Member

After the latest Doctrine Common release, a new error popped up in Psalm:

ERROR: PossiblyUndefinedMethod - lib/Doctrine/ORM/UnitOfWork.php:2875:44 - Method (Doctrine\Common\Proxy\Proxy<object>&Doctrine\Common\Proxy\Proxy<object>)::addPropertyChangedListener does not exist (see https://psalm.dev/108)
                                $newValue->addPropertyChangedListener($this);

This looks like a false positive to me, so I decided to regenerate the Psalm baseline to make the build green again.

@derrabus
Regenerate Psalm baseline
7b50141 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus requested a review from greg0ire October 20, 2021 16:22
@derrabus derrabus enabled auto-merge (squash) October 20, 2021 21:22
greg0ire
greg0ire approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member
@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a false positive: the piece of code is preceded by this condition:

                            if (
                                $newValue instanceof NotifyPropertyChanged &&
                                ( ! $newValue instanceof Proxy || $newValue->__isInitialized())
                            ) {

@derrabus derrabus merged commit 6a8dcbc into doctrine:2.10.x Oct 20, 2021
@greg0ire greg0ire added CI Bug and removed CI labels Oct 20, 2021
@derrabus derrabus deleted the sa/psalm-baseline branch October 20, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @greg0ire
0