Updated doctrine/coding-standard to 6.0 #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
| @@ -103,6 +103,7 @@ public static function sortByField($name, $orientation = 1, ?Closure $next = nul | |||
|
|
|||
| return static function ($a, $b) use ($name, $next, $orientation) : int { | |||
| $aValue = ClosureExpressionVisitor::getObjectFieldValue($a, $name); | |||
|
|
|||
There was a problem hiding this comment.
If I revert the change - codesniffer screams:
FILE: lib/Doctrine/Common/Collections/Expr/ClosureExpressionVisitor.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
104 | ERROR | [x] Expected 1 lines after "return", found 0.
| | (SlevomatCodingStandard.ControlStructures.ControlStructureSpacing.IncorrectLinesCountAfterControlStructure)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Need to have a closer look into the slevomat rules to figure out whats going wrong here
There was a problem hiding this comment.
Could you reproduce this and report it to doctrine/coding-standard maybe? We can roll with this patch meanwhile 👍
There was a problem hiding this comment.
Boiled it down to a simple example and open report here: slevomat/coding-standard#635
Updated coding-standard and used
phpcbfto automatically fix them