8000 Comparison startsWith, endsWith by pine3ree · Pull Request #55 · doctrine/collections · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Comparison startsWith, endsWith #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Comparison startsWith, endsWith #55

wants to merge 5 commits into from

Conversation

pine3ree
Copy link
Contributor
@pine3ree pine3ree commented Apr 3, 2015

Trying to propose again a couple of common comparison test (related to contains test).
I also have the related PR for doctrine2 repo ready.

@beberlei
Copy link
Member

For reference, we have contains already, which does a string match on any part of the string.

@mikeSimonson
Copy link
Contributor

@beberlei This seems good to go to me.

mikeSimonson added a commit that referenced this pull request Mar 27, 2016
@mikeSimonson
Merge pull request #78 from mikeSimonson/start_end_with
a079bed 
Rebase of the Comparison startsWith, endsWith PR #55
@mikeSimonson
Copy link
Contributor

merged in #78

@pine3ree pine3ree deleted the patch-1 branch March 27, 2016 18:57
@stof
Copy link
Member
stof commented Mar 29, 2016

Have you sent a PR updating the ORM to support these new operators ?

@mikeSimonson
Copy link
Contributor

@stof Against what code that PR need to be made ?

@stof
Copy link
Member
stof commented Mar 29, 2016

@mikeSimonson the ORM code turning expression into SQL queries for usage in persistent collections: https://github.com/doctrine/doctrine2/blob/c1943624ab1260c629316bab104dc5130c060154/lib/Doctrine/ORM/Persisters/SqlExpressionVisitor.php

@mikeSimonson
Copy link
Contributor

Those are not compositeExpression but comparison ( the method above this one).
It doesn't look like any change is needed there but maybe there https://github.com/doctrine/doctrine2/blob/c1943624ab1260c629316bab104dc5130c060154/lib/Doctrine/ORM/Persisters/Entity/BasicEntityPersister.php#L99 ?

@stof
Copy link
Member
stof commented Mar 29, 2016

hmm yeah, I forgot that the SqlExpressionVisitor actually delegates to each persister to build the comparison.

@grizzm0
Copy link
grizzm0 commented Jun 21, 2017

Any ETA on the ORM support? ;)

I'm not that into the ORM source. Would it be enough to just add them to the comparisonMap?

@Ocramius
Copy link
Member

@grizzm0 nobody made a patch for this, as far as I know. SqlExpressionVisitor is where you want to start :-)

@grizzm0
Copy link
grizzm0 commented Jun 21, 2017

@Ocramius Probably deeper than my understanding of the ORM. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pine3ree @beberlei @mikeSimonson @stof @grizzm0 @Ocramius 30AB
0