Remove deprecated Index behavior #6802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 19, 2025
| */ | ||
| protected array $_columns = []; | ||
| private readonly array $_columns; |
There was a problem hiding this comment.
Maybe this is a good occasion to finally drop these underscores?
There was a problem hiding this comment.
Initially I did that but then decided to revert. The reasons are:
- We already have
$_columnsand$colums, so the former would have to be renamed to say$columnNames, but then the getter that returns it would still remain namedgetColumns(), so the code would get a bit inconsistent. - This way, the
$isPrimaryconstructor parameter would get promoted to a property but$isUniquewouldn't, so again, the could would become a bit more inconsistent.
Eventually, all these properties will go away:
$_columnswill get removed in favor of$columns.$_isPrimarywill get removed in favor ofPrimaryKeyConstraint.$_isUniqueand$_flagswill get replaced by some other properties because currently an index can beUNIQUE,FULLTEXTandSPATIALat the same time, but it doesn't make sense.
46b6f78 to
36533bb
Compare
greg0ire
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The affected behavior was deprecated in #6787 and #6799.