feat: signing reminders #1749
Open
feat: signing reminders #1749
+999
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove signing reminder job
…e monthly and weekly jobs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🚨 @ephraimduncan has 14 pull requests awaiting review. Please consider reviewing them when possible. 🚨 |
|
🚨 @ephraimduncan has 13 pull requests awaiting review. Please consider reviewing them when possible. 🚨 |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the signing reminders feature by introducing new email job definitions and a dedicated reminder handler, while also updating related job configurations and templates.
- Adds new job definitions for hourly and daily reminder emails.
- Introduces a new reminder email handler with logic for sending reminder emails to recipients.
- Updates various job trigger configurations and associated constants to support the new reminder functionality.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/lib/jobs/definitions/emails/send-team-member-left-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-team-member-joined-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-team-deleted-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-signing-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-reminder.handler.ts | Introduces a new handler for processing reminder emails. |
| packages/lib/jobs/definitions/emails/send-rejection-emails.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-recipient-signed-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-password-reset-success-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-hourly-reminder-email.ts | Introduces hourly reminder email job definition. |
| packages/lib/jobs/definitions/emails/send-document-cancelled-emails.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/definitions/emails/send-daily-reminder-email.ts | Introduces daily reminder email job definition. |
| packages/lib/jobs/definitions/emails/send-confirmation-email.ts | Adds event trigger type to job definition. |
| packages/lib/jobs/client/inngest.ts | Updates job definition to handle both cron and event triggers with improved logging. |
| packages/lib/jobs/client/_internal/job.ts | Updates job trigger types to include cron and event triggers. |
| packages/lib/jobs/client.ts | Registers new reminder email jobs with the job client. |
| packages/lib/constants/document-audit-logs.ts | Updates audit logs constants with a new REMINDER email type. |
| packages/email/templates/document-reminder.tsx | Adds a new email template for document reminders. |
| packages/email/template-components/template-document-reminder.tsx | Provides template components for constructing reminder emails. |
| apps/remix/app/routes/_unauthenticated+/team.verify.transfer.$token.tsx | Updates import type name for improved consistency. |
| apps/remix/app/components/general/document/document-edit-form.tsx | Updates document form to include the new reminderInterval field. |
Comments suppressed due to low confidence (1)
packages/lib/jobs/client/inngest.ts:38
- [nitpick] The variable name 'fn' is ambiguous; consider renaming it to a more descriptive name such as 'jobFunction' to improve code clarity.
let fn: InngestFunction.Any;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo