8000 fix: remove preconnect font links by ephraimduncan · Pull Request #1798 · documenso/documenso · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove preconnect font links #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2025
Merged

fix: remove preconnect font links #1798

merged 4 commits into from
Jun 18, 2025

Conversation

ephraimduncan
Copy link
Contributor
@ephraimduncan ephraimduncan commented May 15, 2025 •
edited
Loading

Fix #1787

@vercel Vercel
Copy link
vercel bot commented May 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 2:22am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Jun 18, 2025 2:22am
prd-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 2:22am
stg-app ⬜️ Ignored (Inspect) Jun 18, 2025 2:22am
prd-openpage-api ⬜️ Skipped (Inspect) Jun 18, 2025 2:22am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 15, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch fix/remove-preconnect-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

🚨 @ephraimduncan has 12 pull requests awaiting review. Please consider reviewing them when possible. 🚨

@ElTimuro ElTimuro mentioned this pull request May 15, 2025
Closed
6 tasks
@dguyen dguyen force-pushed the fix/remove-preconnect-links branch from 22b8b5c to 259fcd2 Compare June 11, 2025 01:48
@vercel vercel bot temporarily deployed to Preview – prd-openpage-api June 11, 2025 01:48 Inactive
@dguyen
Copy link
Collaborator
dguyen commented Jun 11, 2025

I don't think this is going to work correctly, it seems like some font-weights are missing

See the font-bold difference on the documents page compared to staging

@ElTimuro
Copy link
Member

@ephraimduncan pls review for the other fonts david mentioned

@vercel vercel bot temporarily deployed to Preview – prd-openpage-api June 17, 2025 11:29 Inactive
@ephraimduncan ephraimduncan requested a review from dguyen June 17, 2025 11:36
@vercel vercel bot temporarily deployed to Preview – prd-openpage-api June 18, 2025 02:19 Inactive
@dguyen dguyen merged commit 039cd7d into main Jun 18, 2025
15 checks passed
@dguyen dguyen deleted the fix/remove-preconnect-links branch June 18, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguyen dguyen dguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Fonts is unlawfull in EU
3 participants
@ephraimduncan @dguyen @ElTimuro
0